Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Hardware][Gaudi]add get_name method for HPUAttentionBackend #10667

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

jikunshang
Copy link
Contributor

@jikunshang jikunshang commented Nov 26, 2024

HPUAttentionBackend lack of get_name method. will throw error when choose backend.

cc @kzawora-intel

Signed-off-by: Kunshang Ji <kunshang.ji@intel.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@jikunshang jikunshang changed the title [Hardware][Gaudi]fix hpu_attn get_name [Hardware][Gaudi]add get_name method for HPUAttentionBackend Nov 26, 2024
@jikunshang
Copy link
Contributor Author

@youkaichao @WoosukKwon Please take a look, thanks!

@Isotr0py Isotr0py added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 27, 2024
@youkaichao youkaichao merged commit e85250b into vllm-project:main Nov 27, 2024
50 of 63 checks passed
afeldman-nm pushed a commit to neuralmagic/vllm that referenced this pull request Dec 2, 2024
…oject#10667)

Signed-off-by: Kunshang Ji <kunshang.ji@intel.com>
Signed-off-by: Andrew Feldman <afeldman@neuralmagic.com>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
anko-intel pushed a commit to HabanaAI/vllm-fork that referenced this pull request Feb 12, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants